Use updated barcode to patron_id query #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatimarahman
reviewed
Nov 6, 2024
Comment on lines
-123
to
-148
| logger.info(f"Setting Sierra query timeout to {sierra_timeout} minutes") | ||
| sierra_client.execute_query(f"SET statement_timeout='{sierra_timeout}min';") | ||
| logger.info("Querying Sierra for patron information by barcode") | ||
|
|
||
| initial_log_level = logging.getLogger("postgresql_client").getEffectiveLevel() | ||
| logging.getLogger("postgresql_client").setLevel(logging.CRITICAL) | ||
| finished = False | ||
| num_attempts = 1 | ||
| while not finished: | ||
| try: | ||
| sierra_raw_data = sierra_client.execute_query(sierra_query) | ||
| finished = True | ||
| except PostgreSQLClientError as e: | ||
| if num_attempts < max_sierra_attempts: | ||
| logger.info("Query failed -- trying again") | ||
| num_attempts += 1 | ||
| else: | ||
| logger.error( | ||
| f"Error executing Sierra query {sierra_query}:" "\n{e}" | ||
| ) | ||
| sierra_client.close_connection() | ||
| s3_client.close() | ||
| kinesis_client.close() | ||
| raise e from None | ||
| logging.getLogger("postgresql_client").setLevel(initial_log_level) | ||
|
|
There was a problem hiding this comment.
Just for my own understanding -- you're getting rid of this because of this story right? Just want to double check
There was a problem hiding this comment.
No it's part of this one. The reason we were originally retrying is because the query would time out and fail a bunch. With this new query we don't expect that to happen.
fatimarahman
approved these changes
Nov 6, 2024
fatimarahman
reviewed
Nov 6, 2024
| @@ -6,13 +6,11 @@ PLAINTEXT_VARIABLES: | |||
| SIERRA_DB_PORT: 1032 | |||
| SIERRA_DB_NAME: iii | |||
| REDSHIFT_DB_NAME: production | |||
| ENVISIONWARE_BATCH_SIZE: 500 | |||
| ENVISIONWARE_BATCH_SIZE: 10000 | |||
There was a problem hiding this comment.
Last question -- any specific reason this was upped? Or is it just to improve performance?
There was a problem hiding this comment.
Now that the query is more efficient we can send more barcodes at once!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.